[release/7.0] Fix SQL Server bulk insert edge case (#29669) #29717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#29539 (cherry picked from commit 851e47f)
AndriySvyryd
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29539, backports #29669
Description
In the SQL Server provider, when there are pending bulk inserts (into the same table) and a new command is added which causes the batch to go over the parameter limit, we incorrectly rollback the pending commands and not just the new command.
Customer impact
When inserting a large number of rows in SQL Server, SaveChanges throws if the last command causes us to go over the parameter limit.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Added a test for the affected scenario.
Risk
Low; the fix is quite trivial, and a quirk was added to revert back to older behavior.